Skip to content

Android screenshot tests test fails#13

Draft
richardTingle wants to merge 187 commits into
masterfrom
android-screenshot-tests-test-fails
Draft

Android screenshot tests test fails#13
richardTingle wants to merge 187 commits into
masterfrom
android-screenshot-tests-test-fails

Conversation

@richardTingle

@richardTingle richardTingle commented Jun 5, 2026

Copy link
Copy Markdown
Owner

No description provided.

richardTingle added 30 commits May 2, 2026 18:21
@richardTingle
Make the screenshot tests run in an off frame buffer and correct gamm…
b766025 
…a issues in screenshots
@richardTingle
Make the definition of "the same" a bit more flexible to avoid instab…
97dc3c2 
…ility in the pipelines
@richardTingle
Restore gamma correction
4b84b7b
@richardTingle
Set the colourspace for the off renderTexture
602d25f
@richardTingle
Set the Srgb for the off renderTexture
2a428bc
@richardTingle
Rebake minor visual changes for off frame buffer
59164b3
@richardTingle
Rearrange for submodule screenshot structure
ec05b0d
@richardTingle
Add in dependencies for android
625c35b
@richardTingle
Bring it closer to the android initialiser project
e215ab4
@richardTingle
Temporarily use non local android jme
93d159e
@richardTingle
Simple screenshot test
77f8178
@richardTingle
Wait for emulator
036ab76
@richardTingle
Dont save a snapshot, use mesa
e0cad2a
@richardTingle
Make the emulator logs less likely to hang
9787b0b
@richardTingle
Bit closer to the android-emulator-runner docs
dbf0b9c
@richardTingle
Add logging in test
9f36591
@richardTingle
Try a more modern pixel copy
0780c16
@richardTingle
Capture logcat
b5ef700
@richardTingle
Only get my applications logcat
e897546
@richardTingle
Pull logs inside app step
a938fea
@richardTingle
Prevent snapshots (which are erroring)
808be1c
@richardTingle
Actually grab the logcat
3b02dfc
@richardTingle
Use the actual location of the file
f6c13e4
@richardTingle
Save file to public directory
6b65fbb
@richardTingle
The whole logcat isn't too long
96173d6
@richardTingle
Pull image from quoted location
a0ca84e
@richardTingle
Whole log cat actually a bit much to put in github logs
cf235a3
@richardTingle
Use latch to wait explicitly for write to complete
d5cdeaa
@richardTingle
Clean up the test code
c35e44c
@richardTingle
Go back to scoped storage as permissions do not allow downloads folder
a475397
@richardTingle
More recent java version
0223c9a
@richardTingle
Update location of desktop screenshot tests
ba6ce88
@richardTingle
Merge remote-tracking branch 'official/master' into android-screensho…
1451935 
…t-tests-2

# Conflicts:
#	gradle/libs.versions.toml
#	jme3-screenshot-tests/build.gradle
#	settings.gradle
@richardTingle
Fix AndroidTestHarness for change in AndroidHarnessFragment
6c51634
@richardTingle
Ensure file load still works for screenshot tests
396d57a
@richardTingle
Move reference files within normal resources
812e3d0
@richardTingle
All desktop screenshot tests with their correct base
8da89c0
@richardTingle
Use same layout as in the android example
1d6c109
@richardTingle
Simpler layout
7d8b1f6
@richardTingle
Correct javadoc
ce0befe
@richardTingle
Correct attached image save location
09581c6
@richardTingle
Gen the generated images back from the android run if they are differ…
5691c66 
…ent sizes
@richardTingle
.png suffix on changeed images
ac5b247
@richardTingle
Restore accidentally changed ScenarioPostWater values
6020741
@richardTingle
Rebake images at new size
21f51a2
@richardTingle
Rebake images at new size
151cc8e
@richardTingle
Add missing copywright notices
944c339
@richardTingle
Add missing reference images
c5cab03
@richardTingle
Don't prematurely fail test, allow all images to be collected
b5f9abb
@richardTingle
Add missing images
994d563
@richardTingle
Deliberately mess with images
02653a0
@github-actions

github-actions Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

✅ If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

✨ If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

Contact @richardTingle (aka richtea) for guidance if required

@richardTingle richardTingle force-pushed the android-screenshot-tests-test-fails branch from 9f9c577 to e508dc8 Compare June 5, 2026 15:47
@richardTingle richardTingle force-pushed the android-screenshot-tests-test-fails branch from eda80ec to 9087459 Compare June 5, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@richardTingle @8Keep @riccardobl @JNightRider @theMinka @ittaigolde